Skip to content
This repository has been archived by the owner. It is now read-only.

Create table filter partial #77

Merged
merged 2 commits into from Jul 15, 2015
Merged

Create table filter partial #77

merged 2 commits into from Jul 15, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 14, 2015

Instead of using the same (or slightly varied) markup in every filterable table in every app, use a common partial provided by the admin gem.

Simplest usage:

<%= render partial: 'govuk_admin_template/table_filter' %>

Use within table:

<table class="table table-bordered table-hover" data-module="filterable-table">
  <thead>
    <tr class="table-header"></tr>
    <%= render partial: 'govuk_admin_template/table_filter' %>
  </thead></table>

cc @dsingleton

fofr added 2 commits Jul 13, 2015
Instead of using the same (or slightly varied) markup in every
filterable table in every app, use a common partial provided by the
admin gem.
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Jul 14, 2015

I think this is 👍, but worth a second opinion.

edds added a commit that referenced this pull request Jul 15, 2015
Create table filter partial
@edds edds merged commit bb01848 into master Jul 15, 2015
1 check passed
1 check passed
default "Build #118 succeeded on Jenkins"
Details
@edds edds deleted the partials branch Jul 15, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.