Skip to content
This repository has been archived by the owner. It is now read-only.

Show clash between primary topic and additional topic as an error against a field #285

Merged
merged 1 commit into from Jan 23, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jan 22, 2015

Rather than showing the error at the top of the page, show it next to the additional_topic field itself. This matches the duplicate topic error above it.

This makes it easier to spot and fix the tagging problem when saving an edition using ajax. Being worked on as part of https://www.agileplannerapp.com/boards/173808/cards/9007 and https://github.com/alphagov/publisher/tree/ajax-save

Rather than showing the error at the top of the page, show it next to
the additional_topic field itself. This matches the duplicate topic
error above it.

This makes it easier to spot and fix the tagging problem when saving an
edition using ajax.

https://www.agileplannerapp.com/boards/173808/cards/9007
@fofr fofr force-pushed the topic-validator branch from 2533c5a to 341315a Jan 23, 2015
danielroseman added a commit that referenced this pull request Jan 23, 2015
Show clash between primary topic and additional topic as an error against a field
@danielroseman danielroseman merged commit bac4ccb into master Jan 23, 2015
1 check passed
1 check passed
default "Build #340 succeeded on Jenkins"
Details
@danielroseman danielroseman deleted the topic-validator branch Jan 23, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.