Skip to content
This repository has been archived by the owner on Jan 2, 2024. It is now read-only.

Retry when publisher confirms fail #7

Open
KushalP opened this issue Jul 2, 2014 · 2 comments
Open

Retry when publisher confirms fail #7

KushalP opened this issue Jul 2, 2014 · 2 comments

Comments

@KushalP
Copy link
Contributor

KushalP commented Jul 2, 2014

We're currently monitoring publisher confirms as part of the QueueConnection object but aren't doing anything in the event that a given publish fails. You can see an example of how this can be done from the author of the amqp library we're using here: streadway/amqp#104 (comment)

@mattbostock
Copy link
Contributor

Noting this here because I think it's relevant:

We set the mandatory and immediate flags to false when publishing a message.

This could lead to circumstances in which messages are silently dropped.

We may need to look at implementing a listener with Channel.NotifyReturn to handle any undeliverable messages when calling publish as per if we enable either of these flags:
http://godoc.org/github.com/streadway/amqp#Channel.Publish

@KushalP
Copy link
Contributor Author

KushalP commented Jul 31, 2014

Agreed. This is all related to the possibility that the AMQP server tells us it couldn't confirm receipt of a message.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants