This repository has been archived by the owner on Apr 4, 2018. It is now read-only.
Remove empty string arguments from component variants #206
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rails this was causing rendering errors, eg, an empty string
of
error
, egerror => ''
is treated as true in ruby, and wascausing the default form-group component to render as an error
when copied from fractal.
Removing empty string arguments from variants makes the examples
simpler and easier to understand / reason about.