Skip to content
This repository has been archived by the owner on Apr 4, 2018. It is now read-only.

Remove empty string arguments from component variants #206

Merged
merged 1 commit into from Feb 10, 2017

Conversation

dsingleton
Copy link
Contributor

  1. In rails this was causing rendering errors, eg, an empty string
    of error, eg error => '' is treated as true in ruby, and was
    causing the default form-group component to render as an error
    when copied from fractal.

  2. Removing empty string arguments from variants makes the examples
    simpler and easier to understand / reason about.

1. In rails this was causing rendering errors, eg, an empty string
   of `error`, eg `error => ''` is treated as true in ruby, and was
   causing the default form-group component to render as an error
   when copied from fractal.

2. Removing empty string arguments from variants makes the examples
   simpler and easier to understand / reason about.
@gemmaleigh gemmaleigh merged commit 029150d into master Feb 10, 2017
@gemmaleigh gemmaleigh deleted the drop-empty-variant-strings branch February 10, 2017 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants