Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classic analytics logic into classic tracker #166

Merged
merged 1 commit into from Mar 16, 2015
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 13, 2015

  • Scope only applies to classic analytics, that’s where the default should be applied
  • Index and Scope only need to be numbers in classic (in Universal index becomes “dimension1”)
  • Add a setDimension call to classic for API parity (easier switching from classic to universal without simultaneous tracking)
* Scope only applies to classic, that’s where the default should be
applied
* Index and Scope only need to be numbers in classic (in Universal
index becomes “dimension1”)
* Add a setDimension call to classic for API parity (easier switching
from  classic to universal without simultaneous tracking)
benilovj added a commit that referenced this pull request Mar 16, 2015
Move classic analytics logic into classic tracker
@benilovj benilovj merged commit 5199b77 into master Mar 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benilovj benilovj deleted the analytics-refinements branch Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.