Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track a print pageview on print attempt #167

Merged
merged 2 commits into from Mar 16, 2015
Merged

Track a print pageview on print attempt #167

merged 2 commits into from Mar 16, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 16, 2015

Match the old static behaviour and technique of prefixing /print in front of the current path then tracking a pageview.

PR corresponds with the following change to static:
https://github.com/alphagov/static/compare/delete-print-tracking

Story: https://www.pivotaltracker.com/story/show/88896084

cc @benilovj @wryobservations

fofr added 2 commits Mar 16, 2015
Matching the old static technique of prefixing `/print` in front of the
current path.
Avoid repeated print attempts within 3 seconds of the original (this
was the original intent, but the time period was set to 1 second)
benilovj added a commit that referenced this pull request Mar 16, 2015
Track a print pageview on print attempt
@benilovj benilovj merged commit fc5c426 into master Mar 16, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@benilovj benilovj deleted the print-pageview branch Mar 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.