Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch download tracking to use events #214

Merged
merged 1 commit into from Aug 10, 2015
Merged

Switch download tracking to use events #214

merged 1 commit into from Aug 10, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 10, 2015

Events show a user intent, but are less likely to be interpreted incorrectly – it shows that a user clicked a link on a page, rather than the file was successfully downloaded and viewed.

It should avoid inflating our pageview numbers, prevent an increase in our cardinality and leave open a more complete pageview tracking solution from logs (eg for direct downloads).

* Events will not pollute the pageview tracking
* Events show a user intent, but are less likely to be interpreted
incorrectly, it shows a click rather than a pageview
@edds
Copy link
Contributor

@edds edds commented Aug 10, 2015

👍

fofr added a commit that referenced this pull request Aug 10, 2015
Switch download tracking to use events
@fofr fofr merged commit 4a4774e into master Aug 10, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the download-tracking-events branch Aug 10, 2015
fofr added a commit to alphagov/static that referenced this pull request Aug 10, 2015
Pick up changes to download link tracker:
alphagov/govuk_frontend_toolkit#214
fofr added a commit that referenced this pull request Aug 10, 2015
Update docs to correspond with changes in
#214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.