Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests against jQuery 1.11.3 #226

Merged
merged 2 commits into from Nov 11, 2015
Merged

Run tests against jQuery 1.11.3 #226

merged 2 commits into from Nov 11, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 11, 2015

  • Switch to the official jQuery package
  • Use 1.11.3 which is the version currently used by GOV.UK
  • Fix SelectionButton tests for jQuery 1.11.3
    • Checkbox and radio states should be set using prop rather than attr
    • Trigger reliably changes the state of a checkbox, we don’t need to set the attr as well – doing both is confusing and might achieve the opposite of what’s intended

This raises the issue of how we should communicate that:

  • jQuery is required for using some of the JS
  • Which version of jQuery we should nominally support, what's the minimum version
  • Potentially running tests against a set of jQuery libraries

cc @robinwhittleton @dsingleton

fofr added 2 commits Nov 11, 2015
* Switch to the official jQuery package
* Use 1.11.3 which is currently used by Static
* Checkbox and radio states should be set using prop rather than attr
* Trigger reliably changes the state of a checkbox, we don’t need to
set the attr as well – doing both is confusing and might achieve the
opposite of what’s intended
@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Nov 11, 2015

Good fix 👍

robinwhittleton added a commit that referenced this pull request Nov 11, 2015
Run tests against jQuery 1.11.3
@robinwhittleton robinwhittleton merged commit a3e992d into master Nov 11, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the bump-jquery branch Mar 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.