Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename tests from `SomeFileSpec.js` to `some-file.spec.js` to match source #231

Merged
merged 1 commit into from Nov 27, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 20, 2015

The source files are in the format: some-file.js, change the tests from SomeFileSpec.js to a similar some-file.spec.js.

When searching for a JS file both the source and the test can be easily found.

The source files are in the format: `some-file.js`, change the tests
from `SomeFileSpec.js` to a similar `some-file.spec.js`.

When searching for a JS file both the source and the test can be easily
found.
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Nov 27, 2015

I'm kind of indifferent to this. The change makes sense for development reasons, but camelCase feels a bit more JS-y (totally unqualified hot take there).

I'd be happy merging this. Plus it's a good example of coding/naming conventions from FET2 discussions (CC @robinwhittleton)

@robinwhittleton
Copy link
Contributor

@robinwhittleton robinwhittleton commented Nov 27, 2015

I’m indifferent. On the basis of consistency at least 👍

dsingleton added a commit that referenced this pull request Nov 27, 2015
Rename tests from `SomeFileSpec.js` to `some-file.spec.js` to match source
@dsingleton dsingleton merged commit 9932298 into master Nov 27, 2015
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@dsingleton dsingleton deleted the rename-tests branch Nov 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.