Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 4.8.1 #254

Merged
merged 1 commit into from Feb 18, 2016
Merged

Version 4.8.1 #254

merged 1 commit into from Feb 18, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Feb 18, 2016

Update DEFRA brand colour to new green (PR #249)

Update DEFRA brand colour to new green (PR #249)
@benlovell
Copy link
Contributor

@benlovell benlovell commented Feb 18, 2016

Is this classed as a bug-fix?

jamiecobbett added a commit that referenced this pull request Feb 18, 2016
Version 4.8.1
@jamiecobbett jamiecobbett merged commit 3eb01c5 into master Feb 18, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@jamiecobbett jamiecobbett deleted the bump-version branch Feb 18, 2016
@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Feb 18, 2016

@benlovell I thought about that and decided that a colour change doesn't really fit into semver. Thinking about it again, I suppose you could call it a MINOR because we're "adding functionality in a backwards-compatible manner".

@benlovell
Copy link
Contributor

@benlovell benlovell commented Feb 18, 2016

@jamiecobbett It's no biggy. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.