Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Brexit CTA link from checker start page #1249

Merged
merged 1 commit into from Jan 6, 2020

Conversation

@huwd
Copy link
Contributor

huwd commented Jan 6, 2020

Trello: https://trello.com/c/9gDW14vq/264-remove-brexit-sidebar-link-on-the-checker-start-page

Why

Currently we want to show a contextual Brexit sidebar on start pages for any content that is tagged to /brexit or /world/brexit.
This link serves as a call to action to bring people back to the Brexit landing page.
The landing page in turn links to the checker as a major feature, which itself has a start page.
Currently that start page shows this sidebar, putting the user in a loop between the start page and landing page.

What

To prevent this we add an additional condition to the show_brexit_cta? method, only used in this repo in _show_contextual_sidebar.html.erb,
causing it to return false if the content_id matches the content_id for the Brexit checker start page

Visual Changes

Tested:
Example of startup page
Screenshot_2020-01-06 Brexit check what you need to do if there is no deal

Example of other Brexit taxon page
Screenshot_2020-01-06 How to prepare if the UK leaves the EU with no deal

Currently we want to show a contextual Brexit sidebar on start pages for any content that is tagged to /brexit or /world/brexit.
This link serves as a call to action to bring people back to the Brexit landing page.
The landing page in turn links to the checker as a major feature, which itself has a start page.
Currently that start page shows this sidebar, putting the user in a loop between the start page and landing page.

To prevent this we add an additional condition to the show_brexit_cta? method, only used in this repo in _show_contextual_sidebar.html.erb,
causing it to return false if the content_id matches the content_id for the Brexit checker start page
@huwd huwd merged commit 364e75c into master Jan 6, 2020
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@huwd huwd deleted the no-brexit-sidebar-on-checker-startpage branch Jan 6, 2020
@vanitabarrett vanitabarrett mentioned this pull request Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.