Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Namespace components hosted in gem #136
Move all components hosted by the gem to be within
Usage in app is now like:
Before namespacing, in an app you would see something like
Equally it led to peculiar includes like:
If an app and the gem both have a component with the same name, it is not clear which one would have precedence. By setting a namespace it's explicit.
This is a breaking change
Example of updating government-frontend after this is versioned:
I found that I needed to explicitly import the css3 mixin for box sizing in 607b10b
An alternative to the long namespace would be to have
I avoided that in this PR because I thought it would make it unclear what was needed for components and what was needed for the component guide.
I can't block this but I think having such long verbose names will be annoying for people, since it'll make their markup much harder to read.
Edit: We've had big problems with magic in the past, and this change makes govuk_publishing_components a lot less magic than static which is a good change