Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional print stylesheet to component guide #19

Merged
merged 1 commit into from Aug 8, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 7, 2017

Some components require print styles to render correctly.

Add an option to include print styles in the component guide. Apps handle print stylesheets differently – make this a configuration option without a default.

Some components require print styles to render correctly.

Add an option to include print styles in the component guide. Apps
handle print stylesheets differently – make this a configuration option
without a default.
fofr added a commit to alphagov/government-frontend that referenced this pull request Aug 7, 2017
* Create contents list helper for styles shared between print and
screen (just the table layout styles for lists with formatted numbers)
* Disable default print styles
* Use our own indent to nest dashed items when printing
* Hide the default list item marker when printing for numbered and
nested lists
* Put print styles on all pages

Component guide requires fix before print styles are visible:
alphagov/govuk_publishing_components#19
@nickcolley nickcolley merged commit 40d2beb into master Aug 8, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@nickcolley nickcolley deleted the print-styles branch Aug 8, 2017
fofr added a commit to alphagov/government-frontend that referenced this pull request Aug 8, 2017
* Create contents list helper for styles shared between print and
screen (just the table layout styles for lists with formatted numbers)
* Disable default print styles
* Use our own indent to nest dashed items when printing
* Hide the default list item marker when printing for numbered and
nested lists
* Put print styles on all pages

Component guide requires fix before print styles are visible:
alphagov/govuk_publishing_components#19
@fofr fofr mentioned this pull request Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.