Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't print the feedback forms #224

Closed
wants to merge 1 commit into from
Closed

Don't print the feedback forms #224

wants to merge 1 commit into from

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 15, 2018

The previous report a problem forms were hidden from print view.

  • Hide question and forms from print

Fix for: https://github.com/alphagov/static/pull/1331/files#r174788786

Currently looks like this on the homepage:

screen shot 2018-03-15 at 13 59 01

The previous report a problem forms were hidden from print view.

* Hide question and forms from print
@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 15, 2018

Not sure why this isn't doing the trick:
https://github.com/alphagov/govuk_publishing_components/blob/master/app/assets/stylesheets/govuk_publishing_components/components/print/_feedback.scss

Maybe the component print styles aren't being included by all apps?

@tijmenb
Copy link
Contributor

@tijmenb tijmenb commented Mar 15, 2018

Yeah, I seem to have conveniently forgotten to implement the component print styles in most apps:

https://docs.google.com/spreadsheets/d/1J-0IPyr2ycPuw1IWOIoX0o9Tk9nF35D0DJdsj_ylLQE/edit#gid=0

Only calendars, smart-answers, whitehall do the right thing, all others either don't have a print stylesheet at all or have the wrong thing (only the step by step nav).

@fofr
Copy link
Contributor Author

@fofr fofr commented Mar 15, 2018

Closing in favour of applying component print styles in apps.

@fofr fofr closed this Mar 15, 2018
@maxgds maxgds deleted the dont-print-feedback branch Nov 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.