Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visited link colour on focus for white feedback links #239

Merged
merged 1 commit into from Mar 22, 2018

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Mar 22, 2018

When the link was visited (i.e. user had visited /contact/govuk, the
:visited styles would be more specific than the focus styles provided
by govuk_template, meaning the link would stay white and be hard to
read.

Steps to reproduce:

Before

screen shot 2018-03-22 at 13 18 00

After

screen shot 2018-03-22 at 13 24 21

@tijmenb tijmenb temporarily deployed to govuk-publishing-compon-pr-239 Mar 22, 2018 Inactive
When the link was visited (i.e. user had visited `/contact/govuk`, the
`:visited` styles would be more specific than the focus styles provided
by govuk_template, meaning the link would stay white and be hard to
read.
@fofr fofr merged commit cd471d0 into master Mar 22, 2018
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the feedback-focus-link-color branch Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.