Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.0 #39

Merged
merged 1 commit into from Aug 29, 2017
Merged

Version 1.0.0 #39

merged 1 commit into from Aug 29, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 25, 2017

All documentation will need updating when upgrading (see PR #37):

  • Rename fixtures to examples in YAML documentation
  • Nest example data within a named block to give examples more features
All documentation will need updating when upgrading (see PR #37):

* Rename fixtures to examples in YAML documentation
* Nest example data within a named block to give examples more features
* Nest example data within a named block to give examples more features

Steps to upgrade:
* Rename fixtures in YAML files to "examples"
* Nest data for each example in a `data:` block

This comment has been minimized.

@vanitabarrett

vanitabarrett Aug 29, 2017
Contributor

Maybe bit picky, but I feel like the last 2 bullet points just re-word the 2 bullet points before it - are they both needed?

This comment has been minimized.

@nickcolley

nickcolley Aug 29, 2017
Contributor

Probably not but maybe not worth blocking on?

@fofr fofr merged commit dc7c930 into master Aug 29, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the version-1 branch Aug 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.