Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly extend namespaced controller #5

Merged
merged 1 commit into from Jul 26, 2017
Merged

Explicitly extend namespaced controller #5

merged 1 commit into from Jul 26, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 26, 2017

Depending on load ordering the value of “ApplicationController” can vary.
See: rails/rails#12168

If you visited an application page before visiting the component guide, the guide would render within the host application’s layout rather than the gem’s.

  • Be explicit about which ApplicationController we want to use
  • Include what was a failing test to demonstrate fix

Hat-tip to @h-lame for pointing me in the right direction.

Depending on load ordering the value of “ApplicationController” can
vary. See: rails/rails#12168

If you visited an application page before visiting the component guide,
the guide would render within the host application’s layout rather than
the gems.

* Be explicit about which ApplicationController we want to use
* Include what was a failing test to demonstrate fix
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Jul 26, 2017

Nice work @fofr and @h-lame 👍

@fofr fofr merged commit 9222c53 into master Jul 26, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the fix-dependency-order branch Jul 26, 2017
fofr added a commit that referenced this pull request Jul 27, 2017
* Include body and accessibility acceptance criteria on component pages
PR #6
* Fix load ordering bug which would sometimes cause the component guide
to use the app’s layout PR #5
@fofr fofr mentioned this pull request Jul 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.