Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
Make it clear when aXe has failed, succeeded or found errors #64
Easiest to review with
Our integration tests in government-frontend couldn't easily check that aXe was present and running on each page. If aXe itself had an error we swallowed the error and CI would report that as "no accessibility errors".
Refactoring to fix this unveiled one of these false positives: a problem with restoreScroll on pages with SVGs – a bug in aXe itself. Added a tweak to prevent this from erroring in the future. See: dequelabs/axe-core#525
Use body class to indicate accessibility tests have run and their state. Classes can be used in integration tests to confirm tests are running.
* Classes will be used in integration tests to confirm tests are running * eg need to confirm JS has run and not thrown any errors * Also removes a method shortcut which set `err` to a success value * Update called methods to handle empty lists