Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use local govuk_components for static’s component guide #74

Merged
merged 2 commits into from Sep 20, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 19, 2017

Best to review 153f2a0 first.

I needed to refactor integration tests to have more static component guide tests. I've split the large component guide test into a set of files based on features in fa4344a.

See alphagov/slimmer#208 for more details

  • Update slimmer to >= 11.1.0
  • When rendering static’s component guide avoid loading govuk_components over the network by using Slimmer’s local component resolver.
  • Stub components that the dummy app would otherwise get from Slimmer (slimmer’s local resolver has no concept of a test mode as files ought to be available)
@fofr fofr force-pushed the local-slimmer branch from 8ff141a to 6dfe5f6 Sep 19, 2017
fofr added 2 commits Sep 19, 2017
See alphagov/slimmer#208

* Update slimmer to >= 11.1.0
* Use LocalGovukComponents when on static, avoiding i18n chains and
calls over the network to itself
* Stub components that the dummy app would otherwise get from Slimmer
(slimmer’s local resolver has no concept of a test mode as files ought
to be available)
* Re-include the appropriate module when running static tests as
initialiser config can't recreate ApplicationController
@fofr fofr force-pushed the local-slimmer branch from 6dfe5f6 to 153f2a0 Sep 19, 2017
@fofr fofr requested review from h-lame and nickcolley Sep 20, 2017
@h-lame
h-lame approved these changes Sep 20, 2017
Copy link
Contributor

@h-lame h-lame left a comment

This looks good to me.

@fofr fofr merged commit 45c9484 into master Sep 20, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the local-slimmer branch Sep 20, 2017
@andysellick andysellick mentioned this pull request Sep 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.