Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ApplicationRecord file #8

Merged
merged 1 commit into from Jul 28, 2017
Merged

Remove ApplicationRecord file #8

merged 1 commit into from Jul 28, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 28, 2017

govuk_publishing_components doesn’t use ActiveRecord
This file was included as boilerplate when the gem was generated.

Without this fix the govuk_publishing_components gem doesn't run on Heroku when used with government-frontend (alphagov/government-frontend#416):

2017-07-28T14:08:21.579099+00:00 app[web.1]: /app/vendor/bundle/ruby/2.3.0/gems/govuk_publishing_components-0.3.0/app/models/govuk_publishing_components/application_record.rb:2:in 'module:GovukPublishingComponents': uninitialized constant GovukPublishingComponents::ActiveRecord (NameError)
2017-07-28T14:08:21.579101+00:00 app[web.1]: from /app/vendor/bundle/ruby/2.3.0/gems/govuk_publishing_components-0.3.0/app/models/govuk_publishing_components/application_record.rb:1:in `<top (required)>'

govuk_publishing_components doesn’t use ActiveRecord
This file was included as boilerplate when the gem was generated.
@fofr fofr merged commit abb94db into master Jul 28, 2017
1 check passed
1 check passed
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the remove-application-record branch Jul 28, 2017
fofr added a commit that referenced this pull request Jul 28, 2017
* Remove ApplicationRecord files from gem PR #8
@fofr fofr mentioned this pull request Jul 28, 2017
andysellick added a commit that referenced this pull request Aug 8, 2017
* Remove ApplicationRecord files from gem PR #8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.