Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable duplicate ID rule in axe tests #80

Merged
merged 2 commits into from Sep 20, 2017
Merged

Disable duplicate ID rule in axe tests #80

merged 2 commits into from Sep 20, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 20, 2017

Components sometimes contain IDs. These get repeated on the component
guide page. This repetition is not representative of actual usage,
leading to a false positive accessibility failure.

This specifically affects the document_footer component in static where
we rely on a specific component ID to link to from elsewhere in the
page – so it can’t be dynamic and unique with each use.

fofr added 2 commits Sep 20, 2017
`ActiveSupport.halt_callback_chains_on_return_false` is being removed
in 5.2. We aren’t using this setting.
Components sometimes contain IDs. These get repeated on the component
guide page. This repetition is not representative of actual usage,
leading to a false positive accessibility failure.

This specifically affects the document_footer component in static where
we rely on a specific component ID to link to from elsewhere in the
page – so it can’t be dynamic and unique with each use.
@nickcolley nickcolley merged commit d0cbe37 into master Sep 20, 2017
1 check passed
@nickcolley nickcolley deleted the disable-axe-id-rule branch Sep 20, 2017
@fofr
Copy link
Contributor Author

@fofr fofr commented Sep 21, 2017

Wondering if we could use markup to disable certain rules per components.

@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented Sep 21, 2017

Yeah if we wanted to do this more often we could have a data api

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants