Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove component guide hover styles #81

Merged
merged 2 commits into from Sep 22, 2017
Merged

Remove component guide hover styles #81

merged 2 commits into from Sep 22, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 22, 2017

This would flash a box around the component on hover. Box shadows look
out of place and the effect can be confusing, especially with
components that have a solid background.

The govuk- namespace is deprecated.

Removes

screen shot 2017-09-22 at 08 56 51

fofr added 2 commits Sep 22, 2017
We versioned from master after this PR got merged (but following the
initial version bump PR). This is because the master task failed on
Jenkins and was re-run on a later commit.
This would flash a box around the component on hover. Box shadows look
out of place and the effect can be confusing, especially with
components that have a solid background.

The `govuk-` namespace is deprecated.
@fofr fofr requested a review from vanitabarrett Sep 22, 2017
@fofr fofr merged commit eae2c2c into master Sep 22, 2017
1 check passed
1 check passed
@govuk-ci
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the remove-highlight branch Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants