Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render accessibility violations in component guide #82

Merged
merged 3 commits into from Sep 22, 2017
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Sep 22, 2017

  • Refactor incomplete warnings JS to work with both incomplete and violations
  • Improve typography of HTML output - large text and increased spacing between text
  • Update to cope better with multiple reasons (eg an image without an alt tag can have many possible solutions)
  • Add integration tests for both warnings and violations

screen shot 2017-09-22 at 11 09 06

fofr added 3 commits Sep 22, 2017
Refactor to allow method re-use for violations
* Refactor incomplete warnings JS to work with both incomplete and
violations
* Improve typography of HTML output
* Update to cope better with multiple reasons (eg an image without an
alt tag can have many possible solutions)
@fofr fofr requested a review from vanitabarrett Sep 22, 2017
@fofr fofr changed the title Render violations in component guide Render accessibility violations in component guide Sep 22, 2017
@vanitabarrett
Copy link
Contributor

@vanitabarrett vanitabarrett commented Sep 22, 2017

To me, the list of reasons/solutions under the violation title is a bit confusing - it makes it look like all of those attributes need to be added for the element to be accessible. Not sure what can be done about that though

@fofr
Copy link
Contributor Author

@fofr fofr commented Sep 22, 2017

@vanitabarrett Yeah, that's the list aXe gives you. Any one of them could be used to fix the issue. I think the top one in the list is usually the most appropriate. Not sure there's much we can do.

Copy link
Contributor

@vanitabarrett vanitabarrett left a comment

Looks good 👍

@fofr fofr merged commit 413ce80 into master Sep 22, 2017
1 check passed
1 check passed
@govuk-ci
continuous-integration/jenkins/branch This commit looks good
Details
@fofr fofr deleted the add-violations branch Sep 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants