Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up and modernise govuk_template.html #208

Merged
merged 4 commits into from Apr 20, 2016
Merged

Clean up and modernise govuk_template.html #208

merged 4 commits into from Apr 20, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 19, 2016

Use HTML5 preferred values.

Reduce page load by:

Also removes line breaks in the <head> tag and puts conditional comments onto a single line where appropriate.

fofr added 4 commits Apr 19, 2016
Reduce page load for everything that uses the template. The `end` tags
are obvious, while the latest icon size guidance is best found in Apple
documentation, eg
https://developer.apple.com/library/safari/documentation/AppleApplicatio
ns/Reference/SafariWebContent/ConfiguringWebApplications/ConfiguringWebA
pplications.html
A `<script>` tag has the default type of “text/javascript”:
https://developer.mozilla.org/en/docs/Web/HTML/Element/script
https://www.w3.org/TR/html5/scripting-1.html#script

“The default, which is used if the attribute is absent, is
"text/javascript”.”
Mostly whitespace changes. Condense template’s output, and group by
function. Remove unnecessary line breaks.
@tvararu
Copy link
Contributor

@tvararu tvararu commented Apr 20, 2016

👍

1 similar comment
@tombye
Copy link
Contributor

@tombye tombye commented Apr 20, 2016

👍

@fofr fofr merged commit 2e19bda into master Apr 20, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr deleted the no-html-comments branch Apr 20, 2016
fofr added a commit that referenced this pull request Apr 22, 2016
- Reduce file size of template: removes HTML comments, `type`
attributes on scripts, and uses HTML5 charset declaration. #208
- Switch external link media query to be mobile first #205
- Sass file cleanups
  - Replace old grid mixins with newer grid from frontend toolkit #134
  - Remove duplicate grey variables #201
@fofr fofr mentioned this pull request Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.