Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use text-colour for headings in footer #217

Merged
merged 1 commit into from May 26, 2016
Merged

Use text-colour for headings in footer #217

merged 1 commit into from May 26, 2016

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented May 26, 2016

This used to be a custom grey variable set to #0b0c0c but was converted to footer-text, which made the headings too grey (see #201)

Switch back to the darker colour to improve contrast, use $text-colour instead.

cc @gemmaleigh

Before

screen shot 2016-05-26 at 15 10 19

After

screen shot 2016-05-26 at 15 10 47

This used to be a custom grey variable set to `#0b0c0c` but was
converted to `footer-text`, which made the headings too grey.

Switch back to the darker colour to improve contrast, use $text-colour
instead.
@nickcolley
Copy link
Contributor

@nickcolley nickcolley commented May 26, 2016

Looks good to me 👍

@nickcolley nickcolley merged commit 4807292 into master May 26, 2016
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@fofr fofr mentioned this pull request May 26, 2016
@36degrees 36degrees deleted the fix-greys branch Apr 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants