convert admin to use same test/lint standard as the main pipelines #682
Conversation
image name has changed, and we use ON_CONCOURSE for the variable
| params: {format: oci} | ||
| - get: nginx-image | ||
| - get: docker-cache/nginx-image | ||
| resource: nginx-image |
There was a problem hiding this comment.
Do we need Nginx? Pretty sure we just use Puma.
There was a problem hiding this comment.
it's used by the fake-register
|
|
||
| for pid in ${pids[*]}; do | ||
| wait "$pid" || true # we don't care about the return code of docker loading | ||
| wait "$pid" |
There was a problem hiding this comment.
Just out of curiosity, we now care about the return code of docker loading?
There was a problem hiding this comment.
ah, explanation for this one.
This occurred when the cache wasn't populated, and relates to the old line 14.
[[ -f "govwifi-admin-prebuilt/image.tar" ]] && docker load -qi "govwifi-admin-prebuilt/image.tar" & pids[3]=$!
The & pids[3]=$! is run on the whole statement, not just the part after the condition check.
This means that for when the file doesn't exist, the process of that statement will return an exit code of 1 due to the [[ ... ]] returning falsely.
adding wait || true was a hack to work around the issue as I didn't fully understand the cause before.
With the move to globbing, the only issues we'll get are ones we want to raise
No description provided.