Revert "Use separate content items for licence-finders" #105
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reverts #104
#104 almost worked as expected. However there is a route that the new content items do not pick up.
Switching from
/licence-finderbeing prefix to exact, and then making each of the child pages their own content items works for pages like/sectors,/browse-sectors,/browse-sectors/childand/activities.When clicking the link "choose your area of interest", the app makes a request to
/licence-finder/browse-sectors.json– this route doesn't make it to the app as technically it's a prefix from licence-finder. That feature is broken.@binaryberry