Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Use separate content items for licence-finders" #105

Closed
wants to merge 1 commit into from

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 20, 2017

Reverts #104

#104 almost worked as expected. However there is a route that the new content items do not pick up.

Switching from /licence-finder being prefix to exact, and then making each of the child pages their own content items works for pages like /sectors, /browse-sectors, /browse-sectors/child and /activities.

When clicking the link "choose your area of interest", the app makes a request to /licence-finder/browse-sectors.json – this route doesn't make it to the app as technically it's a prefix from licence-finder. That feature is broken.

@binaryberry

@fofr
Copy link
Contributor Author

@fofr fofr commented Jun 20, 2017

Closing in favour of #106

@fofr fofr closed this Jun 20, 2017
@rubenarakelyan rubenarakelyan deleted the revert-104-separate-content-items branch Jan 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.