Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete start page #108

Merged
merged 3 commits into from Jun 20, 2017
Merged

Delete start page #108

merged 3 commits into from Jun 20, 2017

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 20, 2017

/licence-finder is now published by Publisher and served by Frontend.

  • Delete start page template, controller and tests
  • Stop sending start page to rummager. Essentially undoes: #83
  • Remove start page parts of content item presenter

https://trello.com/c/zboJadd9/409-3-republish-licence-finder-start-page-as-a-transaction-page-and-remove-hardcoded-version

fofr added 2 commits Jun 19, 2017
The start page is now a transaction published by Publisher and served
by Frontend
Essentially undoes: #83

* Keeps rummager in services as it’s still used as replacement to
content_api
@fofr fofr requested a review from binaryberry Jun 20, 2017
Copy link
Contributor

@binaryberry binaryberry left a comment

One minor comment, but looks good otherwise!

end

def update_type
'minor'
end

def route_type
'exact'
'prefix'

This comment has been minimized.

@binaryberry

binaryberry Jun 20, 2017
Contributor

Could we change this in the payload instead and get rid of this method?

This comment has been minimized.

@fofr

fofr Jun 20, 2017
Author Contributor

Updated

* Refactor LicenceFinderFormContentItemPresenter into
LicenceFinderContentItemPresenter
@fofr fofr force-pushed the delete-start-page branch from 566760c to adf5f7c Jun 20, 2017
@fofr fofr merged commit de888fd into master Jun 20, 2017
2 checks passed
2 checks passed
continuous-integration/jenkins/branch This commit looks good
Details
security/snyk No new vulnerabilities
Details
@fofr fofr deleted the delete-start-page branch Jun 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.