New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export broken links for local authority #363

Merged
merged 3 commits into from Jan 11, 2019

Conversation

Projects
None yet
2 participants
@emmabeynon
Copy link
Contributor

emmabeynon commented Jan 10, 2019

For https://trello.com/c/eGGNb2a4/6-add-button-to-download-all-broken-links-for-a-council

screen shot 2019-01-10 at 15 43 36

This adds a button on local authority show pages which allows users to download a CSV of all the broken links for the given local authority.

@emmabeynon emmabeynon force-pushed the export-bad-links-for-local-authority branch 2 times, most recently from 31c031d to d3f5a2a Jan 10, 2019

@emmabeynon emmabeynon requested a review from sihugh Jan 10, 2019

emmabeynon added some commits Jan 10, 2019

Export broken links for a local authority
This adds functionality to export a CSV of all broken links for enabled
services for a given local authority. At this point we aren't expecting this to
be used in a rake task like the existing `export_links` method; rather it will
enable a user to download the CSV via the UI, which will be added in a later
commit. As such it didn't seem to make sense to follow the existing pattern of
creating a class method that creates a new instance of the class.
Add button to download CSV of broken links
The CSV includes broken links for a particular local authority.

@emmabeynon emmabeynon force-pushed the export-bad-links-for-local-authority branch from d3f5a2a to c47e8cd Jan 10, 2019

@sihugh

sihugh approved these changes Jan 11, 2019

@emmabeynon emmabeynon merged commit b1b08d9 into master Jan 11, 2019

2 checks passed

continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/security No security issues found
Details

@emmabeynon emmabeynon deleted the export-bad-links-for-local-authority branch Jan 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment