Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Bootstrap to 3.3 #338

Merged
merged 2 commits into from Dec 4, 2014
Merged

Upgrade Bootstrap to 3.3 #338

merged 2 commits into from Dec 4, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Dec 2, 2014

Bump admin gem to pick up Bootstrap 3.3 (see alphagov/govuk_admin_template#53)
For testing, everything on this branch should look and behave as it did before.

Also:

  • Add missing app_title variable to layout
@tommyp
Copy link
Contributor

@tommyp tommyp commented Dec 4, 2014

Any big frontend changes in the Bootstrap diff we should be aware of?

@fofr
Copy link
Contributor Author

@fofr fofr commented Dec 4, 2014

@tommyp I haven't come across any visible changes in any of the apps with the exception of a slightly lighter grey for navbar text (which improves the contrast). It's a bugfix release.

@tommyp
Copy link
Contributor

@tommyp tommyp commented Dec 4, 2014

Happy to merge this then 👍

tommyp added a commit that referenced this pull request Dec 4, 2014
Upgrade Bootstrap to 3.3
@tommyp tommyp merged commit eea858a into master Dec 4, 2014
1 check passed
1 check passed
default Build #1453 succeeded on Jenkins
Details
@tommyp tommyp deleted the upgrade-bootstrap branch Dec 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.