Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Remove EU logo from finder #520

Merged
merged 1 commit into from Jul 16, 2015
Merged

[DO NOT MERGE] Remove EU logo from finder #520

merged 1 commit into from Jul 16, 2015

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 14, 2015

Should not be deployed until new entrance page is published with logo

The finder is no longer an “entrance page to content” and doesn’t strictly need a logo. The entrance page will instead be a detailed guide.

https://trello.com/c/on5LaLnh/

The finder is no longer an “entrance page to content” and doesn’t
strictly need a logo.

https://trello.com/c/on5LaLnh/
@benilovj
Copy link
Contributor

@benilovj benilovj commented Jul 14, 2015

👍

@jackscotti
Copy link
Contributor

@jackscotti jackscotti commented Jul 14, 2015

Is this logo going to be used for something else? If not I think the asset should be deleted from asset-manager by creating a new task, see: https://github.com/alphagov/asset-manager/tree/master/bin

@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 14, 2015

@jackscotti It's being used on a detailed guide.

@jamiecobbett
Copy link
Contributor

@jamiecobbett jamiecobbett commented Jul 16, 2015

The new detailed guide has been published, so this can now be merged.

jamiecobbett added a commit that referenced this pull request Jul 16, 2015
[DO NOT MERGE] Remove EU logo from finder
@jamiecobbett jamiecobbett merged commit b82423d into master Jul 16, 2015
1 check passed
1 check passed
default Build #2091 succeeded on Jenkins
Details
@jamiecobbett jamiecobbett deleted the remove-eu-logo branch Jul 16, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.