Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline ManualBuilder into Manual #978

Merged
merged 2 commits into from Apr 20, 2017
Merged

Conversation

chrisroos
Copy link
Contributor

I don't think the ManualBuilder was adding any real value and think that removing it makes the code easier to understand.

This means that we're only ever instantiating ManualBuilder from
`Manual.build` and will mean that it's easier to inline
`ManualBuilder#call` into `Manual.build`.
Removing this level of indirection should make the code a little easier
to follow.
@chrisroos chrisroos force-pushed the inline-manual-builder-into-manual branch from c815f33 to e99a62a Compare April 20, 2017 11:45
Copy link
Contributor

@chrislo chrislo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@chrisroos
Copy link
Contributor Author

Thanks @chrislo!

@chrisroos chrisroos merged commit 1d0f996 into master Apr 20, 2017
@chrisroos chrisroos deleted the inline-manual-builder-into-manual branch April 20, 2017 12:50
@chrislo chrislo modified the milestone: Simplify Apr 25, 2017
@chrislo chrislo mentioned this pull request Apr 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants