Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jasmine for Javascript testing #110

Merged
merged 6 commits into from Jul 17, 2014
Merged

Add Jasmine for Javascript testing #110

merged 6 commits into from Jul 17, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 11, 2014

  • Configure to avoid default phantomjs download
  • Run javascript tests by default
  • Include govuk-admin-template as jasmine src file
  • Create tested modules for scrolling to an element and starting a chosen select
Paul Hayes added 5 commits Jul 11, 2014
* Run `rails g jasmine:install`
* Configure to avoid default phantomjs download
* Run javascript tests by default
* Required for bootstrap and jquery libraries to be present
* Start chosen select drop downs based on data attributes rather than
CSS classes
* Move inline javascript to re-usable javascript module
@dhwthompson
Copy link
Contributor

@dhwthompson dhwthompson commented Jul 15, 2014

The Jasmine tests aren’t running on Jenkins: I think that’s because jenkins.sh is running the test task manually, rather than falling through to the default.

* We need to run JavaScript tests as well now, which have been added to
the default task
@fofr
Copy link
Contributor Author

@fofr fofr commented Jul 15, 2014

Excellent spot. Fixed in ea17daa

dhwthompson added a commit that referenced this issue Jul 17, 2014
Add Jasmine for Javascript testing
@dhwthompson dhwthompson merged commit a6d0c02 into master Jul 17, 2014
1 check passed
@dhwthompson dhwthompson deleted the jasmine branch Jul 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants