Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.Sign up
GitHub is where the world builds software
Millions of developers and companies build, ship, and maintain their software on GitHub — the largest and most advanced development platform in the world.
No longer redirect the 'show' action to 'edit', instead displaying some basic information about the need and a link to the edit form. This tidies up the needs controller test a bit and updates the integration tests to update a need so they can still navigate to the edit form.
* Create need view prototype * Demark need in a bootstrap well at the top of the view * Include sections for evidence, justification and impact * Use government departmental colours as defined on https://www.gov.uk/service-manual/user-centered-design/resources/colour- palettes.html * Style evidence in the GOV.UK 'big number' manner
In the view mode, we want to use a slightly rephrased form of the impact strings so that they fit into the sentence "If GOV.UK didn't meet this need…". To achieve this, a new helper method is added to the need helper which converts the existing impact into a key which is then looked up in the locale file.
Display all the organisations for a need above the goal. Each org is separated by a comma and space.
Use the Need's attributes to populate the remaining bits of data in the need view. I've added a second need fixture response to assist testing when there are empty values returned from the Need API. This involves adding some new need helper methods to format numbers and percentages in a useful way.
* Generally avoid fighting against bootstrap with extra layers of abstraction * Move theme and variable imports into application, for inclusion everywhere * Improve margin helper classes to avoid specificity problems * Improve semantics of header partial and alignment of button group * Use bootstrap breadcrumb with added margin
I've found the class to be incredibly useful. One of the most common reasons for creating a class is to add/remove margins. This saves having to write a new class with new CSS every time you want to tweak margins on elements - keeping CSS manageable. It also keeps margins in a consistent vertical rhythm and the class is unambiguous.
In some cases, ie when we're already applying custom styles, it makes sense to bundle the margins up into that class, preferably with an extend or mixin to keep margins consistent. In this case we want to keep the base class of block-border quite light, in the future it may make sense to bundle these two together.