Skip to content
This repository has been archived by the owner. It is now read-only.

Temporarily allow nil change-descriptions #34

Merged
merged 1 commit into from Apr 11, 2016
Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Apr 11, 2016

The content-item is erroneously passing through a nil change_description that the front-end can’t currently handle. While that’s being investigated we should prevent the front-end from failing,
so that updated travel advice content is available to users.

The content-item is erroneously passing through a nil
change_description that the front-end can’t currently handle. While
that’s being investigated we should prevent the front-end from failing,
so that updated travel advice content is available to users.
@elliotcm elliotcm merged commit a7dbafc into master Apr 11, 2016
1 check passed
1 check passed
default Build #156 succeeded on Jenkins
Details
@elliotcm elliotcm deleted the fix-nil-change-note branch Apr 11, 2016
@@ -45,6 +45,7 @@ def last_reviewed_or_updated_at
# has a latest update label, so we can strip this out.
# Avoids: "Latest update: Latest update - …"
def latest_update
return nil unless change_description.present?

This comment has been minimized.

@dougdroper

dougdroper Apr 11, 2016
Contributor

nil is redundant here:
return unless change_description.present? does the same thing

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.