Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Returns the outcome statistics for the job on the API call. #627

Merged
merged 1 commit into from Aug 25, 2016

Conversation

minglis
Copy link
Contributor

@minglis minglis commented Aug 23, 2016

BREAKING CHANGE FOR THE ADMIN APP

  • Refactors the JOBS api to use the notifications history table to build up the statuses for the notifications.
  • Groups by status
  • returns a new block on the API response

{
'statistics' [{
'status': 'created, 'count': 1,
...
}]
}

@@ -9,7 +9,7 @@
from tests import create_authorization_header
from tests.app.conftest import (
sample_job as create_job,
sample_notification as create_sample_notification)
sample_notification as create_sample_notification, sample_notification)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

importing sample_notification twice with different aliases

@leohemsted
Copy link
Contributor

apart from that 👍

@minglis minglis merged commit 415f241 into master Aug 25, 2016
@pcraig3 pcraig3 deleted the update-job-page-query-2 branch November 28, 2016 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants