[#133036569] Fix TF destroy for Metrics ELB. #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This failed because both listeners were referencing the same policy. Destroying the first resource failed because it attempted to delete the policy as well as the attachment, but the policy was still in use by the other listener. Using a policy per listener avoids this conflict.
|
Can't really argue with this, lgtm |
benhyland
pushed a commit
that referenced
this pull request
Dec 12, 2016
[#133036569] Fix TF destroy for Metrics ELB.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The destroy failed because both listeners were referencing the same policy.
Destroying the first resource failed because it attempted to delete the
policy as well as the attachment, but the policy was still in use by the
other listener.
Using a policy per listener avoids this conflict.
How to review
Deploy from this branch as far as cf-terraform. Run the destroy-cloudfoundry pipeline, and verify it succeeds.
Who can review
Anyone but myself.