New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#141705365] Document the use of MySQL #44

Merged
merged 2 commits into from Jun 28, 2017

Conversation

Projects
None yet
4 participants
@paroxp
Copy link
Member

paroxp commented Jun 14, 2017

What

As we're slowly implementing the MySQL support on our platform, we'd
like to have the documentation for our tenants to refer to, when they're
dealing with the service.

How to review

I have mainly copied the entire postgres section and applied minor changes to naming and tools.

Please, see my comments in pivotal story about this PR before merging.

  • Read through the changes

@paroxp paroxp changed the title [WIP][#141705365] Document the use of MySQL [#141705365] Document the use of MySQL Jun 14, 2017


For more details about how the RDS backup system works, see [Amazon's DB Instance Backups documentation](http://docs.aws.amazon.com/AmazonRDS/latest/UserGuide/Overview.BackingUpAndRestoringAmazonRDSInstances.html) [external page].

### Restoring a MySQL service snapshot (experimental)

This comment has been minimized.

@alext

alext Jun 15, 2017

Member

I think we should omit this section because we don't believe this works yet. We have a separate story to enable this for MySQL.

@paroxp paroxp force-pushed the add_mysql_plans_141705365 branch from 47222a9 to 882665c Jun 15, 2017

@bleach bleach self-assigned this Jun 19, 2017

@bleach
Copy link
Contributor

bleach left a comment

In addition to the one typo I noticed, there are some places where we say "postgres is the only backing service"


Amazon RDS has the capability to provide a read replica: a read-only copy of your MySQL database. This can be useful for performance, availability or security reasons.

See the [Amazon RD documentation on read replicas](https://aws.amazon.com/rds/details/read-replicas/) to learn more.

This comment has been minimized.

@bleach

bleach Jun 19, 2017

Contributor

typo: RD should read RDS

This comment has been minimized.

@bleach

bleach Jun 19, 2017

Contributor

Maybe we should fix the original postgres docs too while we're here?

@bleach

This comment has been minimized.

Copy link
Contributor

bleach commented Jun 19, 2017

Oh, and you need to add a line for the new file here, as it doesn't currently appear in the table of contents:

<%= partial 'documentation/deploying_services/postgres' %>

@paroxp paroxp force-pushed the add_mysql_plans_141705365 branch from 882665c to 45b1d07 Jun 19, 2017

paroxp added some commits Jun 19, 2017

Document the use of MySQL
As we're slowly implementing the MySQL support on our platform, we'd
like to have the documentation for our tenants to refer to, when they're
dealing with the service.

@paroxp paroxp force-pushed the add_mysql_plans_141705365 branch from 45b1d07 to 5c6d467 Jun 19, 2017

@paroxp

This comment has been minimized.

Copy link
Member Author

paroxp commented Jun 19, 2017

Applied these changes. Thanks for these.

@bleach

bleach approved these changes Jun 19, 2017

@bleach

This comment has been minimized.

Copy link
Contributor

bleach commented Jun 19, 2017

This all looks good, but we shouldn't merge until alphagov/paas-cf#954 is on its way to or already in production, otherwise we'll confuse our lovely users.

@alext

This comment has been minimized.

Copy link
Member

alext commented Jun 26, 2017

alphagov/paas-cf#954 has been merged. This can be merged once that's reached production.

@dcarley dcarley assigned dcarley and unassigned bleach Jun 28, 2017

@dcarley

This comment has been minimized.

Copy link
Contributor

dcarley commented Jun 28, 2017

I've confirmed that the feature has been deployed to production.

I haven't reviewed the content because other people have.

@dcarley dcarley merged commit 8c7a60b into master Jun 28, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@dcarley dcarley deleted the add_mysql_plans_141705365 branch Jun 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment