Skip to content
This repository has been archived by the owner. It is now read-only.

Add environment specific favicons #201

Merged
merged 2 commits into from Sep 2, 2014
Merged

Add environment specific favicons #201

merged 2 commits into from Sep 2, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Aug 29, 2014

  • Pa rather than P because of the clash with Publisher
* `Pa` rather than `P` because of the clash with Publisher
<% content_for :favicon do %>
<% environment_style = GovukAdminTemplate.environment_style %>
<%= favicon_link_tag environment_style ?
"favicon-#{environment_style}.png" : "favicon.png" %>

This comment has been minimized.

@vinayvinay

vinayvinay Sep 1, 2014
Contributor

it'll be nice to have parenthesis around the ternary operation. at first glance, i thought environment_style is passed as parameter to favicon_link_tag.

vinayvinay added a commit that referenced this pull request Sep 2, 2014
Add environment specific favicons
@vinayvinay vinayvinay merged commit cbe7e22 into master Sep 2, 2014
@vinayvinay vinayvinay deleted the favicons branch Sep 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.