{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":39890170,"defaultBranch":"master","name":"pay-frontend","ownerLogin":"alphagov","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-07-29T11:36:55.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/596977?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1722326497.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"5dc7b358858bad0cc112d76d742e9e103c79539d","ref":"refs/heads/revert-3877-pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-30T08:01:37.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Revert \"PP-12853 Use axios or request retry for Apple Pay Merchant validation depending on configuration\"","shortMessageHtmlLink":"Revert \"PP-12853 Use axios or request retry for Apple Pay Merchant va…"}},{"before":"9b124beaa75b1f9911a0e7cb2c7a34eb46b6d8a2","after":null,"ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-29T15:18:10.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"}},{"before":"2ccba2ed97e2822b43dad6127b32f510c1b83a66","after":"362881047b8b38ac19f08b6f554654a85e0f6aa0","ref":"refs/heads/master","pushedAt":"2024-07-29T15:18:08.000Z","pushType":"pr_merge","commitsCount":4,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Merge pull request #3877 from alphagov/pp-12853-apple-pay-merchant-validation-two-ways\n\nPP-12853 Use axios or request retry for Apple Pay Merchant validation depending on configuration","shortMessageHtmlLink":"Merge pull request #3877 from alphagov/pp-12853-apple-pay-merchant-va…"}},{"before":"3dfbcbe394e07b07b009bf76389517a5f85aadba","after":"9b124beaa75b1f9911a0e7cb2c7a34eb46b6d8a2","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-29T13:51:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Pass certificate and key to HttpsProxyAgent via options\n\nWith this change, we are passing the merchant certificate and key to Axios\nusing HttpsProxyAgent, including them in the options.\n\nFurther information in JIRA.\n\nhttps://payments-platform.atlassian.net/browse/PP-12853","shortMessageHtmlLink":"Pass certificate and key to HttpsProxyAgent via options"}},{"before":"100aa4dc8788d84acd6a8eafc2f5faa8292e35c7","after":"13e7c7bec8925c350e70e5e410040c77ec7fd548","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-29T11:59:27.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] additional pr comments","shortMessageHtmlLink":"[squash] additional pr comments"}},{"before":"5340bfb94f8ac0fde9689138fab67f3494bc0714","after":"100aa4dc8788d84acd6a8eafc2f5faa8292e35c7","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-29T11:51:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] additional backcompat checks","shortMessageHtmlLink":"[squash] additional backcompat checks"}},{"before":"6beb7ec0fbddd060d3445a1122e7e0d71ae1c5fc","after":"5340bfb94f8ac0fde9689138fab67f3494bc0714","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-29T11:32:08.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] additional backcompat checks","shortMessageHtmlLink":"[squash] additional backcompat checks"}},{"before":"62d9d703ed4b6a42113e386b6dbc8040d68598ad","after":"3dfbcbe394e07b07b009bf76389517a5f85aadba","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-29T11:07:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Use axios or request retry for Apple Pay Merchant validation\n\nWith this change, we are introducing a new environment variable to check\nwhether the pay-frontend application should use axios for the Apple Pay\nMerchant Validation.\n\nBy default the new variable will not exist on any environment, therefore\npay-frontend will keep using request retry to operate the Apple Pay Merchant\nValidation.\n\nWhen the new variable is created and set to true, then pay-frontend will use\nAxios, with or without the use of HttpsProxyAgent, in order to operate the\nApple Pay Merchant Validation.\n\nThis will allow us to safely deploy this change to all environments including\nproduction, and crucially it will allow us to test the Apple Pay Merchant\nValidation using axios on the Test environment only by creating the new\nenvironment variable there and setting it to 'true'.\n\nFurther work will be needed to remove the old code and the use of request\nretry once the validation will be successfully operated with axios in all\nenvironments.\n\nNote that for simplicity the old tests for the Apple Pay Merchant Validation\nusing request retry have been saved in a new file called\nold-merchant-validation.controller.test.js, so that it will be easy to simply\ndelete this file once the current way using request retry will be fully\ndiscontinued.\n\nFurther information in Jira.\n\nhttps://payments-platform.atlassian.net/browse/PP-12853","shortMessageHtmlLink":"Use axios or request retry for Apple Pay Merchant validation"}},{"before":"665a7b559b160fee295f2b3363678c2db031ab06","after":null,"ref":"refs/heads/pp-11682-use-axios-in-frontend","pushedAt":"2024-07-26T16:44:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"}},{"before":"4195579fbbab7da5b6df4311a1238e7a56956979","after":"62d9d703ed4b6a42113e386b6dbc8040d68598ad","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-26T16:43:56.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Use axios for ApplePay Merchant Validation with or without proxy","shortMessageHtmlLink":"Use axios for ApplePay Merchant Validation with or without proxy"}},{"before":"f95eecde5b32ec1ca95e4756d4e9053f17c8019a","after":"4195579fbbab7da5b6df4311a1238e7a56956979","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-26T16:40:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Use axios for ApplePay Merchant Validation with or without proxy","shortMessageHtmlLink":"Use axios for ApplePay Merchant Validation with or without proxy"}},{"before":null,"after":"f95eecde5b32ec1ca95e4756d4e9053f17c8019a","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-two-ways","pushedAt":"2024-07-26T15:24:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Revert \"Pp 12853 apple pay merchant validation revert changes\"","shortMessageHtmlLink":"Revert \"Pp 12853 apple pay merchant validation revert changes\""}},{"before":"f95eecde5b32ec1ca95e4756d4e9053f17c8019a","after":null,"ref":"refs/heads/revert-3876-pp-12853-apple-pay-merchant-validation-revert-changes","pushedAt":"2024-07-26T14:24:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"}},{"before":null,"after":"f95eecde5b32ec1ca95e4756d4e9053f17c8019a","ref":"refs/heads/revert-3876-pp-12853-apple-pay-merchant-validation-revert-changes","pushedAt":"2024-07-26T14:20:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"marcotranchino","name":null,"path":"/marcotranchino","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/16342989?s=80&v=4"},"commit":{"message":"Revert \"Pp 12853 apple pay merchant validation revert changes\"","shortMessageHtmlLink":"Revert \"Pp 12853 apple pay merchant validation revert changes\""}},{"before":"02f7971f2d090f9cee8711e6f70f57e23fce73ad","after":"6beb7ec0fbddd060d3445a1122e7e0d71ae1c5fc","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-26T13:44:46.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] pr comments","shortMessageHtmlLink":"[squash] pr comments"}},{"before":"c6bbb94597430cbc79b2a16bb25bc0eea15c5967","after":null,"ref":"refs/heads/dependabot/docker/node-dfc737c","pushedAt":"2024-07-26T10:39:05.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"katstevens","name":"Kat","path":"/katstevens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3492540?s=80&v=4"}},{"before":"15703fb537366fc2b6c143aa7781b1095db0ad61","after":"2ccba2ed97e2822b43dad6127b32f510c1b83a66","ref":"refs/heads/master","pushedAt":"2024-07-26T10:39:03.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"katstevens","name":"Kat","path":"/katstevens","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/3492540?s=80&v=4"},"commit":{"message":"Merge pull request #3873 from alphagov/dependabot/docker/node-dfc737c\n\nBump node from `a7e7de2` to `dfc737c`","shortMessageHtmlLink":"Merge pull request #3873 from alphagov/dependabot/docker/node-dfc737c"}},{"before":"65f87e85252b65b9653e48387214160e532ede23","after":"02f7971f2d090f9cee8711e6f70f57e23fce73ad","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-26T09:12:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] pr comments","shortMessageHtmlLink":"[squash] pr comments"}},{"before":"7ee07af2d6b5fe4d5e947285b2f63541870ab2b1","after":"65f87e85252b65b9653e48387214160e532ede23","ref":"refs/heads/pp-12546/hold_completed_payments_in_state","pushedAt":"2024-07-25T16:21:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"nlsteers","name":"Nathaniel Steers","path":"/nlsteers","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/1949148?s=80&v=4"},"commit":{"message":"[squash] pr comments","shortMessageHtmlLink":"[squash] pr comments"}},{"before":"2405f26afd307c8465fcaa21d0d6ddf1fd937c28","after":null,"ref":"refs/heads/pp-12853-apple-pay-merchant-validation-revert-changes","pushedAt":"2024-07-24T14:14:29.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"}},{"before":"82291dbf74eefa798256f3a1ec0da4dbd8df7f62","after":"15703fb537366fc2b6c143aa7781b1095db0ad61","ref":"refs/heads/master","pushedAt":"2024-07-24T14:14:27.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"Merge pull request #3876 from alphagov/pp-12853-apple-pay-merchant-validation-revert-changes\n\nPp 12853 apple pay merchant validation revert changes","shortMessageHtmlLink":"Merge pull request #3876 from alphagov/pp-12853-apple-pay-merchant-va…"}},{"before":"ec45301243c23f9ffabaab5419b6ec060d2cbbf9","after":"2405f26afd307c8465fcaa21d0d6ddf1fd937c28","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-revert-changes","pushedAt":"2024-07-24T13:57:08.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"Reverts 2 Apple pay mechant validation fixes that were tried\non the test env but are not working and therefore cannot be released\nto PROD.\n\nRevert \"PP-12853 Apple pay merchant validation - fix env name\"\n\nThis reverts commit 5450a8e48d48c56cbf1c085796d902db20850c79.\n\nRevert \"PP-12853 Update apple pay merchant validation to use Axios\"\n\nThis reverts commit 0c4ab162a38c65a7a7e325135a91fcf4dbc80675.","shortMessageHtmlLink":"Reverts 2 Apple pay mechant validation fixes that were tried"}},{"before":null,"after":"ec45301243c23f9ffabaab5419b6ec060d2cbbf9","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-revert-changes","pushedAt":"2024-07-24T13:56:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"Reverts 2 Apple pay mechant validation fixes that were tried\non the test env but are not working and therefore cannot be released\nto PROD.\n\nRevert \"PP-12853 Apple pay merchant validation - fix env name\"\n\nThis reverts commit 5450a8e48d48c56cbf1c085796d902db20850c79.\n\nRevert \"PP-12853 Update apple pay merchant validation to use Axios\"\n\nThis reverts commit 0c4ab162a38c65a7a7e325135a91fcf4dbc80675.","shortMessageHtmlLink":"Reverts 2 Apple pay mechant validation fixes that were tried"}},{"before":"5450a8e48d48c56cbf1c085796d902db20850c79","after":null,"ref":"refs/heads/pp-12853-apple-pay-merchant-validation-fix-env-variable","pushedAt":"2024-07-24T13:07:27.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"}},{"before":"c170006d169513782100f5da605035a9f1c154c3","after":"82291dbf74eefa798256f3a1ec0da4dbd8df7f62","ref":"refs/heads/master","pushedAt":"2024-07-24T13:07:25.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"Merge pull request #3875 from alphagov/pp-12853-apple-pay-merchant-validation-fix-env-variable\n\nPP-12853 Apple pay merchant validation - fix env name","shortMessageHtmlLink":"Merge pull request #3875 from alphagov/pp-12853-apple-pay-merchant-va…"}},{"before":null,"after":"5450a8e48d48c56cbf1c085796d902db20850c79","ref":"refs/heads/pp-12853-apple-pay-merchant-validation-fix-env-variable","pushedAt":"2024-07-24T12:52:01.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"PP-12853 Apple pay merchant validation - fix env name\n\n- Correct name of the env variable used to check for the\n proxy:\n - Should be HTTPS_PROXY instead of HTTPS_PROXY","shortMessageHtmlLink":"PP-12853 Apple pay merchant validation - fix env name"}},{"before":"0c4ab162a38c65a7a7e325135a91fcf4dbc80675","after":null,"ref":"refs/heads/pp-12853-update-apple-pay-merchant-validation-with-https-proxy-agent","pushedAt":"2024-07-24T09:49:58.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"}},{"before":"ea0a21c03cdecedb70234c4856a0657f663ae287","after":"c170006d169513782100f5da605035a9f1c154c3","ref":"refs/heads/master","pushedAt":"2024-07-24T09:49:57.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"Merge pull request #3874 from alphagov/pp-12853-update-apple-pay-merchant-validation-with-https-proxy-agent\n\nPP-12853 Update apple pay merchant validation to use Axios","shortMessageHtmlLink":"Merge pull request #3874 from alphagov/pp-12853-update-apple-pay-merc…"}},{"before":"1f7ebfe2891957171596943caa46be10579ce465","after":"0c4ab162a38c65a7a7e325135a91fcf4dbc80675","ref":"refs/heads/pp-12853-update-apple-pay-merchant-validation-with-https-proxy-agent","pushedAt":"2024-07-24T09:34:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"PP-12853 Update apple pay merchant validation to use Axios\n\nWith this change, we are removing the use of `requestretry` from the Merchant Validation Controller which currently uses this module.\n\nWe are replacing it by using Axios directly.\n\nThere is an [Axios bug](https://github.com/axios/axios/issues/4531) when\nusing an SSL proxy.\n\nTherefore, we have had to add the NPM [https-proxy-agent](https://www.npmjs.com/package/https-proxy-agent) as a workaround.\n\nNote that the previous attempted did not pass our QA on the test environment[1].\n\nAlso had to re-generate the .secrets.baseline file due to conflicts from\nmaster.\n\nFurther information in Jira[2].\n\n[1]\nhttps://github.com/alphagov/pay-frontend/pull/3862\n\n[2]\nhttps://payments-platform.atlassian.net/browse/PP-12853","shortMessageHtmlLink":"PP-12853 Update apple pay merchant validation to use Axios"}},{"before":"838fc5c7d0cb583700f750eb0651fc1e5fe5335c","after":"1f7ebfe2891957171596943caa46be10579ce465","ref":"refs/heads/pp-12853-update-apple-pay-merchant-validation-with-https-proxy-agent","pushedAt":"2024-07-24T08:56:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"iqbalgds","name":"Iqbal","path":"/iqbalgds","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/59831992?s=80&v=4"},"commit":{"message":"PP-12853 Update apple pay merchant validation to use Axios\n\nWith this change, we are removing the use of `requestretry` from the Merchant Validation Controller which currently uses this module.\n\nWe are replacing it by using Axios directly.\n\nThere is an [Axios bug](https://github.com/axios/axios/issues/4531) when\nusing an SSL proxy.\n\nTherefore, we have had to add the NPM [https-proxy-agent](https://www.npmjs.com/package/https-proxy-agent) as a workaround.\n\nNote that the previous attempted did not pass our QA on the test environment[1].\n\nAlso had to re-generate the .secrets.baseline file due to conflicts from\nmaster.\n\nFurther information in Jira[2].\n\n[1]\nhttps://github.com/alphagov/pay-frontend/pull/3862\n\n[2]\nhttps://payments-platform.atlassian.net/browse/PP-12853","shortMessageHtmlLink":"PP-12853 Update apple pay merchant validation to use Axios"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEjLR09AA","startCursor":null,"endCursor":null}},"title":"Activity · alphagov/pay-frontend"}