Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jQuery #206

Merged
merged 4 commits into from Jun 13, 2014
Merged

Upgrade jQuery #206

merged 4 commits into from Jun 13, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jun 12, 2014

  • Before moving Publisher to the admin gem, make sure everything works with the newest jQuery
  • Also upgrade jQuery UI
  • Fix uses of .attr() which has subtly changed between jQuery versions
  • Javascript tested and reviewed:
    • Smart checkbox checking on business support pages
    • Sorting and auto slug generation on guides (some bugs found in original code, will address in separate PR)
    • Making changes to a form and being warned to save them
    • Bootstrap modals
    • Creating and editing smart answers/questions/outcomes
fofr added 4 commits Jun 12, 2014
* Upgrade jquery-rails and pin version to match admin gem
* From version 1.8.20 to 1.10.4 (2 years of updates)
* Include only the sortable UI and its dependencies (core, widget,
mouse)
* Necessary so that it works with latest version of jQuery (ie
.browser() has been removed, which it was previously using)
* If the checked attribute hasn’t been set, then later versions of
jQuery return “undefined” for .attr("checked")
* Switch to a more explicit check, .is(“:checked”)
* With `.prop()` we can pass in true or false, rather than a “checked”
string
@dsingleton
Copy link
Contributor

@dsingleton dsingleton commented Jun 13, 2014

LGTM

dsingleton added a commit that referenced this pull request Jun 13, 2014
Upgrade jQuery
@dsingleton dsingleton merged commit 71bc511 into master Jun 13, 2014
1 check passed
1 check passed
default "Build #101 succeeded on Jenkins"
Details
@dhwthompson dhwthompson deleted the upgrade-jquery branch Jun 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.