Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade jQuery #206

Merged
merged 4 commits into from Jun 13, 2014
Merged

Upgrade jQuery #206

merged 4 commits into from Jun 13, 2014

Commits on Jun 12, 2014

  1. Upgrade jQuery to 1.10.2 

    * Upgrade jquery-rails and pin version to match admin gem
    @fofr
    fofr committed Jun 12, 2014
    Copy the full SHA
    e084585 View commit details
    Browse the repository at this point in the history

  2. Upgrade jQuery UI 

    * From version 1.8.20 to 1.10.4 (2 years of updates)
* Include only the sortable UI and its dependencies (core, widget,
mouse)
* Necessary so that it works with latest version of jQuery (ie
.browser() has been removed, which it was previously using)
    @fofr
    fofr committed Jun 12, 2014
    Copy the full SHA
    32d18b3 View commit details
    Browse the repository at this point in the history

  3. Change detection of checked checkbox 

    * If the checked attribute hasn’t been set, then later versions of
jQuery return “undefined” for .attr("checked")
* Switch to a more explicit check, .is(“:checked”)
    @fofr
    fofr committed Jun 12, 2014
    Copy the full SHA
    7d427f4 View commit details
    Browse the repository at this point in the history

  4. Change checkbox values using prop() 

    * With `.prop()` we can pass in true or false, rather than a “checked”
string
    @fofr
    fofr committed Jun 12, 2014
    Copy the full SHA
    c99b511 View commit details
    Browse the repository at this point in the history