Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up diff between publication editions #229

Merged
merged 3 commits into from Jul 7, 2014
Merged

Tidy up diff between publication editions #229

merged 3 commits into from Jul 7, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Jul 4, 2014

  • Reduce red and green contrast against black text, it was very hard to read. Use lighter colours.
  • Put + and - in a column down the left side
  • Don’t put diff in a well, use an empty bootstrap panel with a modified border

Before:
screen shot 2014-07-04 at 18 35 54

After:
screen shot 2014-07-04 at 18 38 38

fofr added 3 commits Jul 4, 2014
* Reduce red and green contrast against black text, it was very hard to
read. Use lighter colours.
* Put + and - in a column down the left side
* Don’t put diff in a well, use an empty bootstrap panel with a
modified border
vinayvinay added a commit that referenced this pull request Jul 7, 2014
Tidy up diff between publication editions
@vinayvinay vinayvinay merged commit 43891d8 into master Jul 7, 2014
1 check passed
1 check passed
default "Build #196 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the tidy-diff branch Jul 7, 2014
@wryobservations
Copy link

@wryobservations wryobservations commented Jul 7, 2014

Looks good to me - much easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.