Default the state filters on the publications page #2312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaylorgds
force-pushed
the
435-default-statuses-view-publications-page
branch
2 times, most recently
from
9226fae
to
553bcda
Compare
When visiting the root page, with no filters set, default the state filters so that only editions in the "pre-published" states are shown, as these are the editions that users of Mainstream Publisher mostly care about. Uses the presence of the title filter as a proxy for whether any filters have been set, since that filter is always present when the 'update filter' button is clicked (even if no title text has been supplied, in which case it will have an empty value).
mtaylorgds
force-pushed
the
435-default-statuses-view-publications-page
branch
from
553bcda
to
cd243dc
Compare
syed-ali-tw
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting the root page, with no filters set, default the state filters so that only editions in the "pre-published" states are shown, as these are the editions that users of Mainstream Publisher mostly care about.
Uses the presence of the title filter as a proxy for whether any filters have been set, since that filter is always present when the 'update filter' button is clicked (even if no title text has been supplied, in which case it will have an empty value).
Trello card