Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve edition history and notes #264

Merged
merged 6 commits into from Oct 9, 2014
Merged

Improve edition history and notes #264

merged 6 commits into from Oct 9, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 9, 2014

  • Developer review
  • Product review
  • Content designer review

https://www.agileplannerapp.com/boards/173808/cards/6039

  • Make edition history and notes full width with improved legibility
  • Make scanning history and changes easier with larger headings and timestamps that follow the style guide
  • Tweak copy to be inline with style guide
  • Move notes forms behind modals to match workflow behaviour and to avoid obscuring the more important history view

Before:
screen shot 2014-10-09 at 11 44 44

After:
screen shot 2014-10-09 at 11 45 47

screen shot 2014-10-09 at 11 46 08

screen shot 2014-10-09 at 11 46 24

fofr added 6 commits Oct 8, 2014
* Notes were restricted to half the page, and within that fact check
email content restricted even further. This made it very hard to read
fact check email content.
* Remove the left/right alignment of note forms and note entries,
giving notes a full width to be viewed
* Put edition notes and important notes side by side
* Render history as a list rather than a definition list, using the
time and the action as the heading.
* Place fact check responses in a blockquote, this styles the emails
with a larger font size and indents them from the title for easier
scanning of headings
* Bring copy closer inline with style guide
* Avoid using “should”
* The notes forms aren’t used as often as the history and notes view,
the forms get in the way.
* Use the same modal mechanism as the workflow buttons to add edition
notes and important notes. (Note that this doesn’t work without
Javascript, but you can’t currently get to this tab if Javascript is
disabled)
* Move preview and factcheck details to beneath tab title
* Add primary-styled buttons to open note modals
@alext
Copy link
Contributor

@alext alext commented Oct 9, 2014

👍 This looks really good.

alext added a commit that referenced this pull request Oct 9, 2014
Improve edition history and notes
@alext alext merged commit e82fd5c into master Oct 9, 2014
1 check passed
1 check passed
@govuk-ci
default "Build #329 succeeded on Jenkins"
Details
@alext alext deleted the better-notes branch Oct 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants