Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove highlighted editions from publications lists #266

Merged
merged 4 commits into from Oct 14, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 10, 2014

When using the "user search" feature the results include a view link. This link takes you to a publication list with the selected edition highlighted, within the context of other editions. Examples:
https://publisher.preview.alphagov.co.uk/user_search?user_filter=BQ06DJyvxdIAJ3Xb-adtmA&string_filter=
https://publisher.preview.alphagov.co.uk/?with=5436bb1740f0b61389000001

Analytics shows this feature was used only 4 times in the last six months, and with questionable usefulness. When asked about the overall user search function, most used the filters on the left of the main publication list. Analytics suggests the same.

  • Simplify templates by removing highlights
  • Update user search results to link to the edition directly, rather than circuitously through the main publication table
  • Remove logic and tests which altered the publication list when a with param was present

(Mostly undoing this commit: 34a6e4a)

cc @fatbusinessman

fofr added 4 commits Oct 10, 2014
Analytics shows this feature, used via the user search tab, was used 4
times in the last six months, and with questionable usefulness.

* Simplify templates by removing highlights
* Update user search results to link to the edition directly, rather
than circuitously through the main publication table
As we are no longer highlighting editions in context there’s no need to
have two different approaches to building the publications presenter.
Change from “view” to “edit”, and use the edit icon. This brings the
search results inline with the main publications table.
dhwthompson added a commit that referenced this pull request Oct 14, 2014
Remove highlighted editions from publications lists
@dhwthompson dhwthompson merged commit 8955dfb into master Oct 14, 2014
1 check passed
1 check passed
default "Build #334 succeeded on Jenkins"
Details
@dhwthompson dhwthompson deleted the remove-with-table-highlight branch Oct 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.