Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak layout of tags on editions #271

Merged

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Oct 23, 2014

Tags don’t change too often, so the fields, which are more complex than simple text inputs, shouldn’t obscure the main content ones.

  • Move tags into a partial
  • Put partial at the bottom of each form
  • Add a tags header and divider to separate fields from rest of form
  • Cleanup spacing of tag fields

screen shot 2014-10-23 at 14 35 00

fofr added 3 commits Oct 23, 2014
Tags don’t change too often, so the fields, which are more complex than
simple text inputs, shouldn’t obscure the main content ones.

* Move tags into a partial
* Put partial at the bottom of each form
* Add a tags header and divider to separate fields from rest of form
* Use a smaller grid width to match earlier form fields
* Nest each item in a form-group for vertical spacing
* Re-word the section explanation
Now the smart answer buttons are not at the bottom of the page, the
fixed workflow buttons obscure them when automating a click.

* Use trigger instead of click_on to always trigger the click on the
right element and avoid poltergeist’s co-ordinate warning
elliotcm added a commit that referenced this pull request Oct 24, 2014
Tweak layout of tags on editions
@elliotcm elliotcm merged commit 1f2e9ec into allow-tagging-of-collections-to-editions Oct 24, 2014
1 check passed
1 check passed
default "Build #347 succeeded on Jenkins"
Details
@elliotcm elliotcm deleted the tweak-tagging-of-collections branch Oct 24, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.