Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced assignee selector #278

Merged
merged 9 commits into from Nov 7, 2014
Merged

Enhanced assignee selector #278

merged 9 commits into from Nov 7, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 6, 2014

https://www.agileplannerapp.com/boards/173808/cards/8121

In user research sessions an obvious improvement to the task of finding a name amongst the long list of assignees (when filtering publications) is to make that list searchable. Select2, which was already being used, can do this out of the box.

  • Switch select2 to pull assets from a gem
  • Remove unused image and script assets already provided by admin gem
  • Bump jasmine gem and admin gem
    • Fix alignment of business support checkboxes
  • Switch user filter to use select2

Before

screen shot 2014-11-06 at 12 29 48

After

screen shot 2014-11-06 at 12 30 03

fofr added 9 commits Nov 5, 2014
* Update to version 3.5.0 of Select 2
* Update Bootstrap 3 Select2 style overrides
* Apply site wide in preparation for user select improvements
  * Remove specific business support javascript includes and styles
* The select2 overrides are more specific and only apply fixes to
elements with a form-control class. Normally this is passed through to
the select2 widget but the business support script is generating a
hidden input
* Add form-control to the hidden input when it’s created
* Checkboxes were using a markup pattern from Bootstrap 2 that appears
to have broken with a Boostrap 3.2 upgrade
* Use the recommended pattern from
http://getbootstrap.com/css/#forms
* Allow users to search the list of users instead of having to scroll
up and down
* Glyphicons and crown come from admin gem
* Select2 assets come from select gem
Shims are already provided via the admin gem
vinayvinay added a commit that referenced this pull request Nov 7, 2014
@vinayvinay vinayvinay merged commit 8b69158 into master Nov 7, 2014
1 check passed
1 check passed
default "Build #378 succeeded on Jenkins"
Details
@vinayvinay vinayvinay deleted the improved-people-selector branch Nov 7, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.