Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show video fields on video formats #282

Merged
merged 3 commits into from Nov 12, 2014
Merged

Only show video fields on video formats #282

merged 3 commits into from Nov 12, 2014

Conversation

@fofr
Copy link
Contributor

@fofr fofr commented Nov 10, 2014

There are 10 published editions with a video, each being a video format. The video URL and summary fields are not used by content designers and simply clutter the edit view of an edition.

  • Restrict video fields to video formats
  • Remove video icons from the publication table
fofr added 3 commits Nov 10, 2014
* Video url and summary fields aren’t used, they just clutter the
edition form
* There are only 10 published videos, all in the video format
* Only video formats will have videos, and that’s guessable from the
format type alone
* Avoid using grid wrappers, the admin gem provides helpers for setting
the maximum width of form elements
alext added a commit that referenced this pull request Nov 12, 2014
Only show video fields on video formats
@alext alext merged commit 0eee9dc into master Nov 12, 2014
1 check passed
1 check passed
default "Build #389 succeeded on Jenkins"
Details
@alext alext deleted the hide-video-fields branch Nov 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.