Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace grid wrappers with input helper classes #283

merged 6 commits into from Nov 12, 2014


Copy link

@fofr fofr commented Nov 11, 2014

Use the input class helpers to restrict widths rather than wrapping them in Bootstrap grid wrappers. This means only the inputs are constrained, any help text or label can run longer which is preferable for smaller inputs.

Recommend reviewing with whitespace changes hidden (use w=1 in url).

  • Fixes compressed inputs in business support form (wrapper within a wrapper was making the inputs smaller than intended)
  • Gives some textareas a bit more vertical height
  • Remove beta help text
fofr added 6 commits Nov 11, 2014
* Avoid using divs as grid wrappers to restrict width of form elements.
The admin gem provides classes for this.
* Remove beta help text, the explanation is extraneous now the feature
has been introduced and understood
* Constrain widths using classes rather than grid wrappers
* Tidy up whitespace for input attributes
* Use more rows for introductory paragraphs (2 isn’t enough for most
content, scrolling the small boxes is painful)
alext added a commit that referenced this pull request Nov 12, 2014
Replace grid wrappers with input helper classes
@alext alext merged commit fbcd91a into master Nov 12, 2014
1 check passed
1 check passed
default "Build #390 succeeded on Jenkins"
@alext alext deleted the input-class-helpers branch Nov 12, 2014
vinayvinay pushed a commit that referenced this pull request Dec 3, 2014
Vinay Patel

also replaced grid wrappers with input helper classes,
continuing with: #283
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.